linux-kernel - Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7db67825-cd14-8085-081d-90f090804724@mediatek.com>
Date: Wed, 23 Oct 2024 14:44:31 +0800
From: Macpaul Lin <macpaul.lin@...iatek.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, "Rob
 Herring" <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>,
	Seiya Wang <seiya.wang@...iatek.com>, Tinghan Shen
	<tinghan.shen@...iatek.com>, Chunfeng Yun <chunfeng.yun@...iatek.com>,
	Alexandre Mergnat <amergnat@...libre.com>, Jian Yang
	<jian.yang@...iatek.com>, Jianguo Zhang <jianguo.zhang@...iatek.com>, "Jieyy
 Yang" <jieyy.yang@...iatek.com>
CC: Bear Wang <bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>,
	Macpaul Lin <macpaul@...il.com>, Sen Chu <sen.chu@...iatek.com>, "Chris-qj
 chen" <chris-qj.chen@...iatek.com>, MediaTek Chromebook Upstream
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, Chen-Yu Tsai
	<wenst@...omium.org>
Subject: Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for
 tphy



On 10/9/24 17:21, Macpaul Lin wrote:
> 
> 
> On 10/8/24 17:09, AngeloGioacchino Del Regno wrote:
>> Il 08/10/24 09:15, Macpaul Lin ha scritto:
>>> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
>>> The error message was:
>>>    t-phy@...30000: 'power-domains' does not match any of the regexes:
>>>      '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>>> Fix this issue by dropping 'power-domains' of u3phy1 node.
>>>
>>> This is because MediaTek tphy dose not need to add mtcmos.  It is not
>>> necessary to add 'power-domains'. If the power of the tphy is turned 
>>> off,
>>> it will affect other functions. From the current USB hardware design
>>> perspective, even if mtcmos is added to the phy, it is always on.
>>>
>>> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and 
>>> evaluation board")
>>> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
>>
>> Reviewed-by: AngeloGioacchino Del Regno 
>> <angelogioacchino.delregno@...labora.com>
> 
> Sorry for bothering, it seems MediaTek internal still have some
> discussion about according to Conor's suggestion:
> 
> [1] 
> https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6 
> 
> 
> Please don't to pick this patch until if MediaTek could have some
> conclusions.

Update: This patch could be dropped since the correct fix in
TPHY's DT Schema has been accepted.

[2] 
https://lore.kernel.org/all/172917936283.288841.9548294790735623997.b4-ty@kernel.org/

>>> ---
>>>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> Changes for v2:
>>>   - Add detail description of the tphy design for explaining the reason
>>>     of this change.
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi 
>>> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>>> index ade685ed2190..1c6f08dde31c 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>>> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@...30000 {
>>>               #address-cells = <1>;
>>>               #size-cells = <1>;
>>>               ranges = <0 0 0x11e30000 0xe00>;
>>> -            power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
>>>               status = "disabled";
>>>               u2port1: usb-phy@0 {
>>
>>
> 
> Thanks!
> Macpaul Lin

Thanks!
Macpaul Lin