linux-kernel - Re: [PATCH v2 1/5] dt-bindings: display: panel: Move flip properties to panel-common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq7usspbou5lj4zz5giw472icd655als7pdik4ito2ziaidkwv@7yrkrgqs462o>
Date: Wed, 23 Oct 2024 09:15:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jakob Hauser <jahau@...ketmail.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, 
	Jessica Zhang <quic_jesszhan@...cinc.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Thierry Reding <thierry.reding@...il.com>, Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, 
	Andrzej Hajda <andrzej.hajda@...el.com>, dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 1/5] dt-bindings: display: panel: Move flip properties
 to panel-common

On Tue, Oct 22, 2024 at 11:33:35PM +0200, Jakob Hauser wrote:
> The flip properties were used by "samsung,s6e8aa0.yaml" only so far. By
> introducing "samsung,s6e88a0-ams427ap24.yaml" they become more common.
> 
> Signed-off-by: Jakob Hauser <jahau@...ketmail.com>
> ---
> Patch is based on current branch drm-misc-next.
> ---
>  .../bindings/display/panel/panel-common.yaml           |  8 ++++++++
>  .../bindings/display/panel/samsung,s6e8aa0.yaml        | 10 ++--------
>  2 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index 0a57a31f4f3d..087415753d60 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -51,6 +51,14 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [0, 90, 180, 270]
>  
> +  flip-horizontal:
> +    description: boolean to flip image horizontally
> +    type: boolean
> +
> +  flip-vertical:
> +    description: boolean to flip image vertically
> +    type: boolean
> +

I actually wonder how or why would you need to flip the images. I
understand rotation, but this is mirror flip, right? Is it for some
transparent displays?

The change is fine, I just really wonder about hardware.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof