linux-kernel - Re: [PATCH v4 2/5] perf/core: Export perf_exclude

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7234670b-b119-44c2-9465-dd4d9451aae7@linux.ibm.com>
Date: Wed, 23 Oct 2024 09:33:11 +0200
From: Thomas Richter <tmricht@...ux.ibm.com>
To: Namhyung Kim <namhyung@...nel.org>, Peter Zijlstra
 <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>
Cc: Kan Liang <kan.liang@...ux.intel.com>,
        Mark Rutland
 <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Sandipan Das <sandipan.das@....com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH v4 2/5] perf/core: Export perf_exclude_event()

On 10/23/24 02:09, Namhyung Kim wrote:
> And increase the dropped_sample count when it returns 1.  Now it can
> track how many samples are dropped due to the privilege filters in
> software events.
> 
> While at it, rename the same function in s390 cpum_sf PMU and also count
> the dropped samples.
> 
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Alexander Gordeev <agordeev@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Cc: Sven Schnelle <svens@...ux.ibm.com>
> Cc: Thomas Richter <tmricht@...ux.ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  arch/s390/kernel/perf_cpum_sf.c |  8 +++++---
>  include/linux/perf_event.h      |  6 ++++++
>  kernel/events/core.c            | 11 +++++++----
>  3 files changed, 18 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c
> index 5b765e3ccf0cadc8..ff9e694f2be45c6b 100644
> --- a/arch/s390/kernel/perf_cpum_sf.c
> +++ b/arch/s390/kernel/perf_cpum_sf.c
> @@ -996,7 +996,7 @@ static void cpumsf_pmu_disable(struct pmu *pmu)
>  	cpuhw->flags &= ~PMU_F_ENABLED;
>  }
>  
> -/* perf_exclude_event() - Filter event
> +/* perf_event_exclude() - Filter event
>   * @event:	The perf event
>   * @regs:	pt_regs structure
>   * @sde_regs:	Sample-data-entry (sde) regs structure
> @@ -1005,7 +1005,7 @@ static void cpumsf_pmu_disable(struct pmu *pmu)
>   *
>   * Return non-zero if the event shall be excluded.
>   */
> -static int perf_exclude_event(struct perf_event *event, struct pt_regs *regs,
> +static int perf_event_exclude(struct perf_event *event, struct pt_regs *regs,
>  			      struct perf_sf_sde_regs *sde_regs)
>  {
>  	if (event->attr.exclude_user && user_mode(regs))
> @@ -1088,8 +1088,10 @@ static int perf_push_sample(struct perf_event *event,
>  	data.tid_entry.pid = basic->hpp & LPP_PID_MASK;
>  
>  	overflow = 0;
> -	if (perf_exclude_event(event, &regs, sde_regs))
> +	if (perf_event_exclude(event, &regs, sde_regs)) {
> +		atomic64_inc(&event->dropped_samples);
>  		goto out;
> +	}
>  	if (perf_event_overflow(event, &data, &regs)) {
>  		overflow = 1;
>  		event->pmu->stop(event, 0);

For the s390 part:

Acked-by: Thomas Richter <tmricht@...ux.ibm.com>

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH

Vorsitzender des Aufsichtsrats: Wolfgang Wendt

Geschäftsführung: David Faller

Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294