linux-kernel - Re: [PATCH v2 0/5] Introduce Owned type and Ownable trait (was: "rust: page: Add support for vmalloc_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zxitz41uPPeloK0o@pollux>
Date: Wed, 23 Oct 2024 10:03:27 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Abdiel Janulgue <abdiel.janulgue@...il.com>
Cc: rust-for-linux@...r.kernel.org, aliceryhl@...gle.com, dakr@...hat.com,
	linux-kernel@...r.kernel.org, airlied@...hat.com,
	miguel.ojeda.sandonis@...il.com, boqun.feng@...il.com
Subject: Re: [PATCH v2 0/5] Introduce Owned type and Ownable trait (was:
 "rust: page: Add support for vmalloc_to_page")

On Wed, Oct 23, 2024 at 01:44:44AM +0300, Abdiel Janulgue wrote:
> Hi all,
> 
> This series introduces the Owned type and Ownable trait which is the v2 of
> "rust: page: Add support for vmalloc_to_page" [0]. This series includes changes
> for firmware as well to make use of the new wrapper.

Please make sure to add all relevant maintainers. Since this includes a firmware
patch, you should make sure to add all firmware maintainers. Remember to use
scripts/get_maintainer.pl.

Also there are a few minor checkpatch warnings. Please also make sure to run
scripts/checkpatch.pl.

Please also make sure to compile the code with `CLIPPY=1` (there are a bunch of
warnings) and make sure to also run the `rustfmt` target (there are some
formatting issues).

I wonder if it would make sense to make `CLIPPY=1` the default and only disable
it by explicitly passing `CLIPPY=0`.

> 
> Changes since v2:
> - Use Owned and Ownable types for constructing Page as suggested in [1]
>   instad of using ptr::read().
> 
> [0] https://lore.kernel.org/rust-for-linux/20241007202752.3096472-1-abdiel.janulgue@gmail.com/
> [1] https://lore.kernel.org/rust-for-linux/ZwUYmunVpzpexGV8@boqun-archlinux/
> 
> Abdiel Janulgue (5):
>   rust: types: add `Owned` type and `Ownable` trait
>   rust: page: Make ownership of the page pointer explicit.
>   rust: page: Extend support to vmalloc_to_page
>   rust: page: Add page_slice_to_page
>   rust: firmware: implement `Ownable` for Firmware
> 
>  rust/kernel/firmware.rs |  31 ++++++-----
>  rust/kernel/page.rs     | 116 +++++++++++++++++++++++++++++++++++-----
>  rust/kernel/types.rs    |  62 +++++++++++++++++++++
>  3 files changed, 184 insertions(+), 25 deletions(-)
> 
> 
> base-commit: 15541c9263ce34ff95a06bc68f45d9bc5c990bcd
> -- 
> 2.43.0
>