[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f7064783-983a-44bd-a9db-fd20f4e50e33@kernel.org>
Date: Wed, 23 Oct 2024 10:55:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: "davem@...emloft.net" <davem@...emloft.net>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
<pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
Vladimir Oltean <vladimir.oltean@....com>,
Claudiu Manoil <claudiu.manoil@....com>, Clark Wang <xiaoning.wang@....com>,
Frank Li <frank.li@....com>,
"christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>,
"linux@...linux.org.uk" <linux@...linux.org.uk>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"horms@...nel.org" <horms@...nel.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>
Subject: Re: [PATCH v4 net-next 03/13] dt-bindings: net: add bindings for NETC
blocks control
On 23/10/2024 10:18, Wei Fang wrote:
>>> +maintainers:
>>> + - Wei Fang <wei.fang@....com>
>>> + - Clark Wang <xiaoning.wang@....com>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - nxp,imx95-netc-blk-ctrl
>>> +
>>> + reg:
>>> + minItems: 2
>>> + maxItems: 3
>>
>> You have one device, why this is flexible? Device either has exactly 2
>> or exactly 3 IO spaces, not both depending on the context.
>>
>
> There are three register blocks, IERB and PRB are inside NETC IP, but NETCMIX
> is outside NETC. There are dependencies between these three blocks, so it is
> better to configure them in one driver. But for other platforms like S32, it does
> not have NETCMIX, so NETCMIX is optional.
But how s32 is related here? That's a different device.
Best regards,
Krzysztof
Powered by blists - more mailing lists