linux-kernel - Re: [PATCH] fgraph: Fix missing unlock in register_ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241023052948.0285eb2c@rorschach.local.home>
Date: Wed, 23 Oct 2024 05:29:48 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Li Huafei <lihuafei1@...wei.com>
Cc: <dan.carpenter@...aro.org>, <mhiramat@...nel.org>,
 <linux-kernel@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>,
 <oe-kbuild@...ts.linux.dev>, <lkp@...el.com>
Subject: Re: [PATCH] fgraph: Fix missing unlock in register_ftrace_graph()

On Thu, 24 Oct 2024 01:04:48 +0800
Li Huafei <lihuafei1@...wei.com> wrote:

> Instead of returning an error, goto the mutex unlock at the end of the
> function.
> 
> Fixes smatch warning:
> 
> kernel/trace/fgraph.c:1317 register_ftrace_graph() warn: inconsistent returns '&ftrace_lock'.
> 
> Fixes: 2c02f7375e65 ("fgraph: Use CPU hotplug mechanism to initialize idle shadow stacks")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202410220121.wxg0olfd-lkp@intel.com/
> Signed-off-by: Li Huafei <lihuafei1@...wei.com>
> ---
>  kernel/trace/fgraph.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
> index 41e7a15dcb50..98fa7b2a4903 100644
> --- a/kernel/trace/fgraph.c
> +++ b/kernel/trace/fgraph.c
> @@ -1259,7 +1259,7 @@ int register_ftrace_graph(struct fgraph_ops *gops)
>  					fgraph_cpu_init, NULL);
>  		if (ret < 0) {
>  			pr_warn("fgraph: Error to init cpu hotplug support\n");
> -			return ret;
> +			goto out;
>  		}
>  		fgraph_initialized = true;
>  		ret = 0;

Actually, I'm thinking we just should use guard(mutex)(&ftrace_lock);

-- Steve