linux-kernel - Re: [PATCH] ucounts: constify sysctl table user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <krio6coieilcbe43cikb3r2hnm2cdve3no6eztgd74dgzzgflv@sy2ehddvy4jm>
Date: Wed, 23 Oct 2024 12:19:03 +0200
From: Joel Granados <joel.granados@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <kees@...nel.org>, 
	Joel Granados <j.granados@...sung.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ucounts: constify sysctl table user_table

On Sun, Aug 25, 2024 at 12:53:14PM +0200, Thomas Weißschuh wrote:
> The data of user_table is never modified,
> but only used as a template to create copies from.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> kernel/ucount.c has no proper maintainer.
> This patch is meant for the sysctl tree.
> ---
>  kernel/ucount.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/ucount.c b/kernel/ucount.c
> index 8c07714ff27d..4f6dd1a30117 100644
> --- a/kernel/ucount.c
> +++ b/kernel/ucount.c
> @@ -70,7 +70,7 @@ static long ue_int_max = INT_MAX;
>  		.extra1		= &ue_zero,			\
>  		.extra2		= &ue_int_max,			\
>  	}
> -static struct ctl_table user_table[] = {
> +static const struct ctl_table user_table[] = {
>  	UCOUNT_ENTRY("max_user_namespaces"),
>  	UCOUNT_ENTRY("max_pid_namespaces"),
>  	UCOUNT_ENTRY("max_uts_namespaces"),
> 
> ---
> base-commit: d2bafcf224f3911b183113b2fcb536c9e90684a3
> change-id: 20240805-sysctl-const-ucount-5da084520770
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@...ssschuh.net>
> 
Makes total sense.

thx

Signed-off-by: Joel Granados <joel.granados@...nel.org>

-- 

Joel Granados