[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <79aca344-b27e-4b77-aa92-6e4c079486e0@ideasonboard.com>
Date: Wed, 23 Oct 2024 14:05:21 +0300
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Steffen Dirkwinkel <lists@...ffen.cc>, dri-devel@...ts.freedesktop.org,
Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Michal Simek <michal.simek@....com>, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: xlnx: zynqmp_disp: layer may be null while releasing
Hi,
On 21/10/2024 16:51, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>
>
> layer->info can be null if we have an error on the first layer in
> zynqmp_disp_create_layers
>
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@...khoff.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 9368acf56eaf..e4e0e299e8a7 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -1200,6 +1200,9 @@ static void zynqmp_disp_layer_release_dma(struct zynqmp_disp *disp,
> {
> unsigned int i;
>
> + if (!layer->info)
> + return;
> +
> for (i = 0; i < layer->info->num_channels; i++) {
> struct zynqmp_disp_layer_dma *dma = &layer->dmas[i];
>
I think this should also have the Fixes tag, but probably not stable
material.
Tomi
Powered by blists - more mailing lists