linux-kernel - Re: [PATCH v3 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add support for MUX IT5205

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0cc68449-a11d-466c-b89d-067b1c2fd7e0@collabora.com>
Date: Wed, 23 Oct 2024 13:07:07 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Macpaul Lin <macpaul.lin@...iatek.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Alexandre Mergnat <amergnat@...libre.com>
Cc: Bear Wang <bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>,
 Macpaul Lin <macpaul@...il.com>,
 Project_Global_Chrome_Upstream_Group@...iatek.com,
 linux-usb@...r.kernel.org, Chris-qj chen <chris-qj.chen@...iatek.com>,
 Fabien Parent <fparent@...libre.com>, Simon Sun <simon.sun@...jingtech.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: mediatek: mt8395-genio-1200-evk: add
 support for MUX IT5205

Il 23/10/24 10:09, Macpaul Lin ha scritto:
> Add ITE IT5205FN (TYPEC MUX) under I2C2 bus and configure its properties;
> also add references to it5205fn from MT6360 TYPE-C connector for TYPEC
> configuration.
> 
> Signed-off-by: Fabien Parent <fparent@...libre.com>
> Signed-off-by: Simon Sun <simon.sun@...jingtech.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> ---
>   .../dts/mediatek/mt8395-genio-1200-evk.dts    | 22 +++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> Changes for v2:
>   - This is a new patch in the v2 patch.
> 
> Changes for v3:
>   - No change.
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> index 83d520226302..4c11c100e7b6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts
> @@ -229,6 +229,21 @@ &i2c2 {
>   	pinctrl-0 = <&i2c2_pins>;
>   	pinctrl-names = "default";
>   	status = "okay";
> +
> +	it5205fn: typec-mux@48 {

You don't need the it5205fn phandle, please drop.

> +		compatible = "ite,it5205";
> +		reg = <0x48>;
> +		vcc-supply = <&mt6359_vibr_ldo_reg>;
> +		mode-switch;
> +		orientation-switch;

compatible
reg
mode-switch
orientation-switch
vcc-supply

Please reorder.

After which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

> +		status = "okay";
> +
> +		port {
> +			it5205_sbu_ep: endpoint {
> +				remote-endpoint = <&mt6360_ssusb_sbu_ep>;
> +			};
> +		};
> +	};
>   };
>   
>   &i2c6 {
> @@ -369,6 +384,13 @@ mt6360_ssusb_ep: endpoint {
>   							remote-endpoint = <&ssusb_ep>;
>   						};
>   					};
> +
> +					port@2 {
> +						reg = <2>;
> +						mt6360_ssusb_sbu_ep: endpoint {
> +							remote-endpoint = <&it5205_sbu_ep>;
> +						};
> +					};
>   				};
>   			};
>   		};