linux-kernel - Re: [PATCH v1 03/17] mm/rmap: use folio_large_nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mot6mb77ijjk3lf2jnz45bz33jequkmsppvrel333assaebkdj@bv4jbfaavwtl>
Date: Wed, 23 Oct 2024 14:22:20 +0300
From: "Kirill A. Shutemov" <kirill@...temov.name>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	cgroups@...r.kernel.org, x86@...nel.org, linux-fsdevel@...r.kernel.org, 
	Andrew Morton <akpm@...ux-foundation.org>, "Matthew Wilcox (Oracle)" <willy@...radead.org>, 
	Tejun Heo <tj@...nel.org>, Zefan Li <lizefan.x@...edance.com>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Koutný <mkoutny@...e.com>, 
	Jonathan Corbet <corbet@....net>, Andy Lutomirski <luto@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH v1 03/17] mm/rmap: use folio_large_nr_pages() in
 add/remove functions

On Thu, Aug 29, 2024 at 06:56:06PM +0200, David Hildenbrand wrote:
> Let's just use the "large" variant in code where we are sure that we
> have a large folio in our hands: this way we are sure that we don't
> perform any unnecessary "large" checks.
> 
> While at it, convert the VM_BUG_ON_VMA to a VM_WARN_ON_ONCE.
> 
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov