linux-kernel - Re: [GIT PULL] bcachefs fixes for 6.12-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxjgcQPzpg1AnH6q@sashalap>
Date: Wed, 23 Oct 2024 07:39:29 -0400
From: Sasha Levin <sashal@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: Kent Overstreet <kent.overstreet@...ux.dev>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-bcachefs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, hch@...radead.org, broonie@...nel.org
Subject: Re: [GIT PULL] bcachefs fixes for 6.12-rc5

On Tue, Oct 22, 2024 at 12:30:38PM -0700, Kees Cook wrote:
>On Tue, Oct 22, 2024 at 03:06:38PM -0400, Sasha Levin wrote:
>> On Tue, Oct 22, 2024 at 01:39:10PM -0400, Kent Overstreet wrote:
>> >
>> > The following changes since commit 5e3b72324d32629fa013f86657308f3dbc1115e1:
>> >
>> >  bcachefs: Fix sysfs warning in fstests generic/730,731 (2024-10-14 05:43:01 -0400)
>> >
>> > are available in the Git repository at:
>> >
>> >  https://github.com/koverstreet/bcachefs tags/bcachefs-2024-10-22
>>
>> Hi Linus,
>>
>> There was a sub-thread on the linus-next discussion around improving
>> telemetry around -next/lore w.r.t soaking time and mailing list reviews
>> (https://lore.kernel.org/all/792F4759-EA33-48B8-9AD0-FA14FA69E86E@kernel.org/).
>>
>> I've prototyped a set of scripts based on suggestions in the thread, and
>> wanted to see if you'd find it useful. A great way to test it out is with
>> a random pull request you'd review anyway :)
>
>This looks really nice to me! Maybe add top-level grade ("B-") based on
>the stats available. You can call it the Nominal Acceptance Grade bot
>(NAGbot). Can so that everyone will pay attention, declare that it is an
>LLM (Large Linus Model).

This is something we need to figure out. If we do do this, then we need
to figure out how to score, and scoring should be different between
merge window and -rc cycles (heck, it should probably be different
between -rc cycles themselves).

>I'd include a count summary "(5 of 26: 19%)"

Ack

>> --------------------
>> a069f014797fd bcachefs: Set bch_inode_unpacked.bi_snapshot in old inode path
>> e04ee8608914d bcachefs: Mark more errors as AUTOFIX
>> f0d3302073e60 bcachefs: Workaround for kvmalloc() not supporting > INT_MAX allocations
>> 3956ff8bc2f39 bcachefs: Don't use wait_event_interruptible() in recovery
>> eb5db64c45709 bcachefs: Fix __bch2_fsck_err() warning
>
>And then maybe limit this to 5 or 10 (imagine a huge PR like netdev or
>drm).

They should never have a huge number of commits here. I think it's
better to just let it explode.

>>
>>
>> Commits that weren't found on lore.kernel.org/all:
>
>"(9 of 26: 35%)"

Ack.

>Nice work!

Thanks!

-- 
Thanks,
Sasha