linux-kernel - Re: [PATCH v3] s390/kdump: make is_kdump_kernel() consistently return "true" in kdump environments only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttd3t3v7.fsf@li-0ccc18cc-2c67-11b2-a85c-a193851e4c5d.ibm.com>
Date: Wed, 23 Oct 2024 14:12:28 +0200
From: Alexander Egorenkov <egorenar@...ux.ibm.com>
To: David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org
Cc: linux-s390@...r.kernel.org, David Hildenbrand <david@...hat.com>,
        Heiko
 Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander
 Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger
 <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH v3] s390/kdump: make is_kdump_kernel() consistently
 return "true" in kdump environments only

Hi David,


David Hildenbrand <david@...hat.com> writes:

> Similarly provide a custom is_kdump_kernel() implementation that will only
> return "true" in kdump environments, and will do so consistently during
> boot.
>
> Update the documentation of is_dump_available().

A small typo here:

is_dump_available() -> dump_available()

> @@ -587,16 +587,16 @@ int smp_store_status(int cpu)
>   *    with sigp stop-and-store-status. The firmware or the boot-loader
>   *    stored the registers of the boot CPU in the absolute lowcore in the
>   *    memory of the old system.
> - * 3) kdump and the old kernel did not store the CPU state,
> - *    or stand-alone kdump for DASD
> - *    condition: OLDMEM_BASE != NULL && !is_kdump_kernel()
> + * 3) kdump or stand-alone kdump for DASD
> + *    condition: OLDMEM_BASE != NULL && !is_ipl_type_dump() == false

Here is a typo in the condition, a redundant '!' before is_ipl_type_dump().

Otherwise, looks very good to me.

Reviewed-by: Alexander Egorenkov <egorenar@...ux.ibm.com> 

Regards
Alex