linux-kernel - Re: [PATCH v3] s390/kdump: make is_kdump_kernel() consistently return "true" in kdump environments only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241023125351.8013-I-hca@linux.ibm.com>
Date: Wed, 23 Oct 2024 14:53:51 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: David Hildenbrand <david@...hat.com>
Cc: Alexander Egorenkov <egorenar@...ux.ibm.com>, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [PATCH v3] s390/kdump: make is_kdump_kernel() consistently
 return "true" in kdump environments only

On Wed, Oct 23, 2024 at 02:22:18PM +0200, David Hildenbrand wrote:
> On 23.10.24 14:12, Alexander Egorenkov wrote:
> > Here is a typo in the condition, a redundant '!' before is_ipl_type_dump().
> > 
> 
> Thanks for catching these! Too much going back and forth ... :)
> 
> > Otherwise, looks very good to me.
> 
> Thanks for the fast review. I assume these can be fixed up when applying.
> But please let me know if a v3 is preferred, and I can send one after
> waiting a couple of days.

Fixed typos, slightly reworded subject and commit message, and applied.
Thanks a lot!