linux-kernel - Re: [PATCH] input/touchscreen: imagis: Fix not used variable 'imagis_3038

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed4ada83-807a-44f5-840a-47b3a77c4eb9@gmail.com>
Date: Wed, 23 Oct 2024 16:28:25 +0300
From: Markuss Broks <markuss.broks@...il.com>
To: Zeng Heng <zengheng4@...wei.com>, raymondhackley@...tonmail.com,
 dmitry.torokhov@...il.com
Cc: linux-input@...r.kernel.org, bobo.shaobowang@...wei.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input/touchscreen: imagis: Fix not used variable
 'imagis_3038_data'

Hello,

On 10/23/24 12:48 PM, Zeng Heng wrote:
> Fix the following compilation warnings:
> drivers/input/touchscreen/imagis.c:422:39: warning: ‘imagis_3038c_data’
> defined but not used [-Wunused-const-variable=]
>    422 | static const struct imagis_properties imagis_3038c_data = {
> drivers/input/touchscreen/imagis.c:415:39: warning: ‘imagis_3038b_data’
> defined but not used [-Wunused-const-variable=]
>    415 | static const struct imagis_properties imagis_3038b_data = {
> drivers/input/touchscreen/imagis.c:407:39: warning: ‘imagis_3038_data’
> defined but not used [-Wunused-const-variable=]
>    407 | static const struct imagis_properties imagis_3038_data = {
> drivers/input/touchscreen/imagis.c:398:39: warning: ‘imagis_3032c_data’
> defined but not used [-Wunused-const-variable=]
>    398 | static const struct imagis_properties imagis_3032c_data = {
>
> Only define the variables 'imagis_303*_data' when the CONFIG_OF
> is enabled.
>
> Fixes: 1e48ee99f603 ("Input: imagis - add supports for Imagis IST3038")
> Signed-off-by: Zeng Heng <zengheng4@...wei.com>
> ---
>   drivers/input/touchscreen/imagis.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c
> index aeabf8d057de..abeae9102323 100644
> --- a/drivers/input/touchscreen/imagis.c
> +++ b/drivers/input/touchscreen/imagis.c
> @@ -395,6 +395,7 @@ static int imagis_resume(struct device *dev)
>   
>   static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume);
>   
> +#ifdef CONFIG_OF
>   static const struct imagis_properties imagis_3032c_data = {
>   	.interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
>   	.touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
> @@ -427,7 +428,6 @@ static const struct imagis_properties imagis_3038c_data = {
>   	.protocol_b = true,
>   };
>   
> -#ifdef CONFIG_OF
>   static const struct of_device_id imagis_of_match[] = {
>   	{ .compatible = "imagis,ist3032c", .data = &imagis_3032c_data },
>   	{ .compatible = "imagis,ist3038", .data = &imagis_3038_data },

Acked-by: Markuss Broks <markuss.broks@...il.com>

- Markuss