linux-kernel - Re: [PATCH] drm/panel: synaptics-r63353: Fix regulator unbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5db25cea-10d5-4ed6-a385-141775a2a8bc@linaro.org>
Date: Thu, 24 Oct 2024 16:02:51 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
 linux-kernel@...r.kernel.org
Cc: linux-amarula@...rulasolutions.com,
 Michael Trimarchi <michael@...rulasolutions.com>,
 David Airlie <airlied@...il.com>, Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Simona Vetter <simona@...ll.ch>,
 Thomas Zimmermann <tzimmermann@...e.de>, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/panel: synaptics-r63353: Fix regulator unbalance

On 24/10/2024 12:50, Dario Binacchi wrote:
> From: Michael Trimarchi <michael@...rulasolutions.com>
> 
> The shutdown function can be called when the display is already
> unprepared. For example during reboot this trigger a kernel
> backlog. Calling the drm_panel_unprepare, allow us to avoid
> to trigger the kernel warning.
> 
> Tested-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>

Could you add a Fixed tag ?


> 
> ---
> 
>   drivers/gpu/drm/panel/panel-synaptics-r63353.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> index 169c629746c7..17349825543f 100644
> --- a/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c
> @@ -325,7 +325,7 @@ static void r63353_panel_shutdown(struct mipi_dsi_device *dsi)
>   {
>   	struct r63353_panel *rpanel = mipi_dsi_get_drvdata(dsi);
>   
> -	r63353_panel_unprepare(&rpanel->base);
> +	drm_panel_unprepare(&rpanel->base);
>   }
>   
>   static const struct r63353_desc sharp_ls068b3sx02_data = {

With that:

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>