[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdXR1dONCFvCm=QekRaw6F-+W1v6-G+xdSWZVhEg0cRCQQ@mail.gmail.com>
Date: Thu, 24 Oct 2024 16:22:42 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, alexandre.belloni@...tlin.com,
magnus.damm@...il.com, p.zabel@...gutronix.de,
linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v4 08/12] arm64: dts: renesas: r9a08g045: Add VBATTB node
Hi Claudiu,
On Sat, Oct 19, 2024 at 10:48 AM Claudiu <claudiu.beznea@...on.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> Add the DT node for the VBATTB IP along with DT bindings for the clock
> it provides.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> ---
>
> Changes in v4:
> - used clock-controller for the vbattb node name
> - move the node near scif0 for ordering
Thanks for the update!
> - set the vbattb_xtal status as disabled to avoid having it exported
> in linux with frequency = 0 in boards that don't use it
That is expected, and perfectly fine.
The clock is referenced from the vbattb node, so IMHO it should not
be disabled.
> - collected tags
> --- a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a08g045.dtsi
> @@ -72,6 +72,18 @@ scif0: serial@...4b800 {
> status = "disabled";
> };
>
> + vbattb: clock-controller@...5c000 {
> + compatible = "renesas,r9a08g045-vbattb";
> + reg = <0 0x1005c000 0 0x1000>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>;
> + clock-names = "bclk", "rtx";
> + #clock-cells = <1>;
> + power-domains = <&cpg>;
> + resets = <&cpg R9A08G045_VBAT_BRESETN>;
> + status = "disabled";
> + };
> +
> i2c0: i2c@...90000 {
> compatible = "renesas,riic-r9a08g045", "renesas,riic-r9a09g057";
> reg = <0 0x10090000 0 0x400>;
> @@ -425,4 +437,12 @@ timer {
> interrupt-names = "sec-phys", "phys", "virt", "hyp-phys",
> "hyp-virt";
> };
> +
> + vbattb_xtal: vbattb-xtal {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + /* This value must be overridden by the board. */
> + clock-frequency = <0>;
> + status = "disabled";
Hence please drop this line.
> + };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists