linux-kernel - Re: [PATCH next] drm/amdgpu: Fix amdgpu_ip_block_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d99db508-3f45-4a9e-b28e-58248b5fc4df@amd.com>
Date: Thu, 24 Oct 2024 10:00:26 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Sunil Khatri <sunil.khatri@....com>
Cc: Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Lijo Lazar <lijo.lazar@....com>,
 Hawking Zhang <Hawking.Zhang@....com>, Ma Jun <Jun.Ma2@....com>,
 Victor Lu <victorchengchi.lu@....com>, Yunxiang Li <Yunxiang.Li@....com>,
 amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm/amdgpu: Fix amdgpu_ip_block_hw_fini()

On 10/24/2024 03:17, Dan Carpenter wrote:
> This NULL check is reversed so the function doesn't work.
> 
> Fixes: dad01f93f432 ("drm/amdgpu: validate hw_fini before function call")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks!

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

Also applied to amd-staging-drm-next.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 91c1f2188498..f12fab13386a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3309,7 +3309,7 @@ static void amdgpu_ip_block_hw_fini(struct amdgpu_ip_block *ip_block)
>   {
>   	int r;
>   
> -	if (ip_block->version->funcs->hw_fini) {
> +	if (!ip_block->version->funcs->hw_fini) {
>   		DRM_ERROR("hw_fini of IP block <%s> not defined\n",
>   			  ip_block->version->funcs->name);
>   	} else {