[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241024150413.518862-1-bigeasy@linutronix.de>
Date: Thu, 24 Oct 2024 16:55:48 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: linux-kernel@...r.kernel.org,
rcu@...r.kernel.org
Cc: "Paul E. McKenney" <paulmck@...nel.org>,
Anna-Maria Behnsen <anna-maria@...utronix.de>,
Davidlohr Bueso <dave@...olabs.net>,
Frederic Weisbecker <frederic@...nel.org>,
Ingo Molnar <mingo@...nel.org>,
Josh Triplett <josh@...htriplett.org>,
Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH v2 0/3] softirq: Use a dedicated thread for timer wakeups on PREEMPT_RT.
Hi,
the following was in the PREEMPT_RT queue since last softirq rework. The
result is that timer wake ups (hrtimer, timer_list) happens in hardirq
processing them requires to wake ksoftirqd. ksoftirqd runs at SCHED_OTHER so it
will compete for resources with all other tasks in the system, potentially
delayed the processing further.
The idea was to let the timers be processed by a dedicated thread
running at low SCHED_FIFO priority.
While looking at it again, it might make sense to have the
pending_softirq flag per-thread to avoid threads with higher priority
picking up softirqs from low-priority threads. This isn't yet a problem
because adding softirqs for processing happens only from threaded
interrupts. So the low-priority thread will wait until the high-priority
thread is done. And the high-priority thread will PI-boost the
low-priority thread until it is done. It would only make sense to make
the flags per-thread once the BH lock is gone.
The patch is limited to PREEMPT_RT. The ksoftirqd bullets from above
apply also to !PREEMPT_RT +threadirqs. Would it make sense to restrict
it to force_irqthreads() instead?
v1…v2: https://lore.kernel.org/all/20241004103842.131014-1-bigeasy@linutronix.de/
Frederick's comments:
- Use __raise_softirq_irqoff() to raise the softirq for !PREEMPT_RT. Also a
lockdep test to ensure that this is always invoked from an IRQ.
- Make raise_ktimers_thread() only OR the flag and nothing else to
align with __raise_softirq_irqoff(). The wake happens on return from
interrupt anyway.
- A comment in timersd_setup() and interrupt.h
- local_pending_timers() => local_timers_pending().
Sebastian
Powered by blists - more mailing lists