linux-kernel - Re: [PATCH] firmware: tegra: bpmp: Revert "firmware: tegra: bpmp: Use scoped device node handling to simplify error paths"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <o4l6z722yzz3hjskeloqfpzypjl5h46ahweziz2k3cwdnw5oeq@pvylkxm35gwt>
Date: Thu, 24 Oct 2024 18:37:49 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Jonathan Hunter <jonathanh@...dia.com>, linux-tegra@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] firmware: tegra: bpmp: Revert "firmware: tegra: bpmp:
 Use scoped device node handling to simplify error paths"

On Tue, Oct 01, 2024 at 10:40:25PM +0200, Krzysztof Kozlowski wrote:
> This reverts commit 8812b8689ee6 ("firmware: tegra: bpmp: Use scoped
> device node handling to simplify error paths") because it was silently
> modified by committer during commit process, by moving declaration of
> 'struct device_node *np' above the initializer/constructor.  Such code
> was not intention of the author, is not conforming to cleanup.h code
> style and decreases the code readability.
> 
> I did not write such code and I did not agree to put my name with such
> commit.
> 
> Original patch:
> https://lore.kernel.org/all/20240816135722.105945-2-krzysztof.kozlowski@linaro.org/
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> It's very strange to see own patches silently modified without any
> explanation in Signed-off-by area.
> ---
>  drivers/firmware/tegra/bpmp.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

Sorry this got burried. I will sometimes do cosmetic cleanups like this
instead of having submitters go through an extra round of review. I
suppose I could've mentioned it specifically, but I thought this was
minor enough that it didn't matter.

The reason why I changed it was because the original didn't conform to
any discernible kind of coding style and I thought it was difficult to
read. I also did go through the cleanup.h documentation to check that
doing it this way was fine. I am aware of the LIFO behavior of these
helpers, but since there's exactly one occurrence of these it's
perfectly fine to do so in this case.

Anyway, I'll revert this as you requested.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)