linux-kernel - Re: [PATCH v3 2/2] dt-bindings: modified ina2xx to match SY24655

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e028943e-2acb-4b19-b2eb-dd603855b3a8@roeck-us.net>
Date: Thu, 24 Oct 2024 09:55:04 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Wenliang <wenliang202407@....com>
Cc: jdelvare@...e.com, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org, robh@...nel.org, conor+dt@...nel.org,
 krzk+dt@...nel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: modified ina2xx to match SY24655

On 10/24/24 01:30, Wenliang wrote:
> Adding Silergy's sy24655 as an adapter chip for Ina2xx drivers.
> 
> Because it is similar to INA226, the supply voltage and pin definitions
> are the same. It also supports IIC communication, with only two
> additional registers added for configuring and calculating average power.
> 

Again, please consult
	Documentation/process/submitting-patches.rst
for both description and subject.

"dt-bindings: Add SY24655 to ina2xx devicetree bindings" or similar
would be a much better subject, and something like

"SY24655 is similar to INA226. Its supply voltage and pin definitions
are therefore the same. Compared to INA226, SY24655 has two additional
registers for configuring and calculating average power."

would be a much better patch description.

Also, as already requested by Conor, please copy the devicetree mailing list
on devicetree patches to enable automated testing.

Thanks,
Guenter

> Signed-off-by: Wenliang <wenliang202407@....com>
> ---
>   Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> index 6ae961732e6b..05a9cb36cd82 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> @@ -20,6 +20,7 @@ description: |
>   properties:
>     compatible:
>       enum:
> +      - silergy,sy24655
>         - ti,ina209
>         - ti,ina219
>         - ti,ina220