linux-kernel - Re: [PATCH] pmdomain: imx: gpcv2: replace dev_err() with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4vws5lnu4efupunha74pdlgtd754w6n2loymgywrxhwm2rqic2@gz4efozdrpqm>
Date: Thu, 24 Oct 2024 19:26:28 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Dario Binacchi <dario.binacchi@...rulasolutions.com>, 
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev, Ulf Hansson <ulf.hansson@...aro.org>, 
	Michael Trimarchi <michael@...rulasolutions.com>, linux-pm@...r.kernel.org, linux-amarula@...rulasolutions.com, 
	Sascha Hauer <s.hauer@...gutronix.de>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>, 
	Fabio Estevam <festevam@...il.com>, Shengjiu Wang <shengjiu.wang@....com>, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pmdomain: imx: gpcv2: replace dev_err() with
 dev_err_probe()

Hallo Marco,

On Thu, Oct 24, 2024 at 01:01:23PM +0200, Marco Felsch wrote:
> On 24-10-24, Dario Binacchi wrote:
> > The patch standardizes the probe() code by replacing the two occurrences
> > of dev_err() with dev_err_probe(). Indeed, dev_err_probe() was used in all
> > other error paths of the probe() function.
> 
> I assume that this paths aren't using dev_err_probe because these paths
> can't return EPROBE_DEFER and therefore dev_err_probe() would use
> dev_err() anyway.

Note that dev_err_probe() has advantages even if the error code isn't
EPROBE_DEFER. In this case it's mentioning the error code.

See also commits
	7065f92255bb ("driver core: Clarify that dev_err_probe() is OK even w/out -EPROBE_DEFER")
	532888a59505 ("driver core: Better advertise dev_err_probe()")

Best regards
Uwe


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)