linux-kernel - Re: [PATCH v5 net-next 09/13] net: enetc: add i.MX95 EMDIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241024180018.i6bizcc5amrapody@skbuf>
Date: Thu, 24 Oct 2024 21:00:18 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Wei Fang <wei.fang@....com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, claudiu.manoil@....com, xiaoning.wang@....com,
	Frank.Li@....com, christophe.leroy@...roup.eu,
	linux@...linux.org.uk, bhelgaas@...gle.com, horms@...nel.org,
	imx@...ts.linux.dev, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, alexander.stein@...tq-group.com
Subject: Re: [PATCH v5 net-next 09/13] net: enetc: add i.MX95 EMDIO support

On Thu, Oct 24, 2024 at 02:53:24PM +0800, Wei Fang wrote:
> The verdor ID and device ID of i.MX95 EMDIO are different from LS1028A
> EMDIO, so add new vendor ID and device ID to pci_device_id table to
> support i.MX95 EMDIO. And the i.MX95 EMDIO has two pins that need to be
> controlled, namely MDC and MDIO.
> 
> Signed-off-by: Wei Fang <wei.fang@....com>
> Reviewed-by: Frank Li <Frank.Li@....com>
> ---
> v5: no changes
> ---
>  drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> index 2445e35a764a..9968a1e9b5ef 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> @@ -2,6 +2,7 @@
>  /* Copyright 2019 NXP */
>  #include <linux/fsl/enetc_mdio.h>
>  #include <linux/of_mdio.h>
> +#include <linux/pinctrl/consumer.h>
>  #include "enetc_pf.h"
>  
>  #define ENETC_MDIO_DEV_ID	0xee01
> @@ -71,6 +72,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
>  		dev_info(&pdev->dev, "Enabled ERR050089 workaround\n");
>  	}
>  
> +	pinctrl_pm_select_default_state(dev);
> +

Not an expert on pinctrl by any means.. but is this needed?
Documentation/driver-api/pin-control.rst says:

| When a device driver is about to probe the device core will automatically
| attempt to issue ``pinctrl_get_select_default()`` on these devices.
| This way driver writers do not need to add any of the boilerplate code
| of the type found below.

The documentation is obsolete, because pinctrl_get_select_default()
doesn't seem to be the current mechanism through which that happens. But
there is a pinctrl_bind_pins() function in really_probe() which looks
like it does that job. So.. is this needed?

Also, pinctrl_pm_select_default_state() seems to be the suspend/resume
(hence _pm_ name) variant of pinctrl_select_default_state(), but this is
called from probe().

>  	err = of_mdiobus_register(bus, dev->of_node);
>  	if (err)
>  		goto err_mdiobus_reg;
> @@ -113,6 +116,7 @@ static void enetc_pci_mdio_remove(struct pci_dev *pdev)
>  
>  static const struct pci_device_id enetc_pci_mdio_id_table[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, ENETC_MDIO_DEV_ID) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_NXP2, PCI_DEVICE_ID_NXP2_NETC_EMDIO) },
>  	{ 0, } /* End of table. */
>  };
>  MODULE_DEVICE_TABLE(pci, enetc_pci_mdio_id_table);
> -- 
> 2.34.1
>