linux-kernel - Re: [PATCH V2 3/4] selftest/mm: Fix typo in virtual_address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-43cbba56-67ba-4f5a-a929-0805662b22bf@palmer-ri-x1c9a>
Date: Thu, 24 Oct 2024 11:00:43 -0700 (PDT)
From: Palmer Dabbelt <palmer@...belt.com>
To: zhangchunyan@...as.ac.cn, akpm@...ux-foundation.org
CC: akpm@...ux-foundation.org, shuah@...nel.org,
  Paul Walmsley <paul.walmsley@...ive.com>, alex@...ti.fr, Charlie Jenkins <charlie@...osinc.com>, linux-mm@...ck.org,
  linux-kselftest@...r.kernel.org, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
  zhang.lyra@...il.com
Subject:     Re: [PATCH V2 3/4] selftest/mm: Fix typo in virtual_address_range

On Tue, 08 Oct 2024 02:41:40 PDT (-0700), zhangchunyan@...as.ac.cn wrote:
> The function name should be *hint* address, so correct it.
>
> Reviewed-by: Charlie Jenkins <charlie@...osinc.com>
> Signed-off-by: Chunyan Zhang <zhangchunyan@...as.ac.cn>
> ---
> V1: https://lore.kernel.org/linux-mm/ZuOuedBpS7i3T%2Fo0@ghost/T/
> ---
>  tools/testing/selftests/mm/virtual_address_range.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c
> index 4e4c1e311247..2a2b69e91950 100644
> --- a/tools/testing/selftests/mm/virtual_address_range.c
> +++ b/tools/testing/selftests/mm/virtual_address_range.c
> @@ -64,7 +64,7 @@
>  #define NR_CHUNKS_HIGH  NR_CHUNKS_384TB
>  #endif
>
> -static char *hind_addr(void)
> +static char *hint_addr(void)
>  {
>  	int bits = HIGH_ADDR_SHIFT + rand() % (63 - HIGH_ADDR_SHIFT);
>
> @@ -185,7 +185,7 @@ int main(int argc, char *argv[])
>  	}
>
>  	for (i = 0; i < NR_CHUNKS_HIGH; i++) {
> -		hint = hind_addr();
> +		hint = hint_addr();
>  		hptr[i] = mmap(hint, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE,
>  			       MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);

Acked-by: Palmer Dabbelt <palmer@...osinc.com>

In case that helps, but this has nothing to do with RISC-V so you might 
need to re-send it so someone else notices.  Though +Andrew, in case 
that's enough...