linux-kernel - Re: [RFC PATCH v1 10/10] net: qrtr: mhi: Report endpoint id in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e178ef4d-3234-4c11-84f5-0a454d198f15@gmail.com>
Date: Thu, 24 Oct 2024 13:06:22 -0500
From: Denis Kenzior <denkenz@...il.com>
To: Chris Lew <quic_clew@...cinc.com>, netdev@...r.kernel.org
Cc: Marcel Holtmann <marcel@...tmann.org>, Andy Gross <agross@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v1 10/10] net: qrtr: mhi: Report endpoint id in sysfs

Hi Chris,

>> @@ -72,6 +72,16 @@ static int qcom_mhi_qrtr_send(struct qrtr_endpoint *ep, 
>> struct sk_buff *skb)
>>       return rc;
>>   }
>> +static ssize_t endpoint_show(struct device *dev,
>> +                 struct device_attribute *attr, char *buf)
>> +{
>> +    struct qrtr_mhi_dev *qdev = dev_get_drvdata(dev);
>> +
>> +    return sprintf(buf, "%d\n", qdev->ep.id);
> 
> %u might be more appropriate because the endpoint id is stored as a u32

Nice catch.  I'll fix it for the next version.

Regards,
-Denis