[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fa1ff3ab-b5c0-4efb-9fd4-81815ba4dd2b@lunn.ch>
Date: Thu, 24 Oct 2024 21:42:01 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jacky Chou <jacky_chou@...eedtech.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, u.kleine-koenig@...libre.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next v3] net: ftgmac100: refactor getting phy device handle
On Tue, Oct 22, 2024 at 04:42:14PM +0800, Jacky Chou wrote:
> Consolidate the handling of dedicated PHY and fixed-link phy by taking
> advantage of logic in of_phy_get_and_connect() which handles both of
> these cases, rather than open coding the same logic in ftgmac100_probe().
>
> Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
> ---
> v2:
> - enable mac asym pause support for fixed-link PHY
> - remove fixes information
> v3:
> - Adjust the commit message
It takes a bit of effort to see it is correct, but it looks O.K. to
me.
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
Powered by blists - more mailing lists