linux-kernel - Re: [PATCH net v2] net: ti: icssg-prueth: Fix 1 PPS sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a0a632e-0b3c-4192-8d00-51d23c15c97e@lunn.ch>
Date: Thu, 24 Oct 2024 21:55:38 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Meghana Malladi <m-malladi@...com>
Cc: vigneshr@...com, horms@...nel.org, jan.kiszka@...mens.com,
	diogo.ivo@...mens.com, pabeni@...hat.com, kuba@...nel.org,
	edumazet@...gle.com, davem@...emloft.net, andrew+netdev@...n.ch,
	linux-kernel@...r.kernel.org, vadim.fedorenko@...ux.dev,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	srk@...com, Roger Quadros <rogerq@...nel.org>, danishanwar@...com
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix 1 PPS sync

> +static inline u64 icssg_readq(const void __iomem *addr)
> +{
> +	return readl(addr) + ((u64)readl(addr + 4) << 32);
> +}
> +
> +static inline void icssg_writeq(u64 val, void __iomem *addr)
> +{
> +	writel(lower_32_bits(val), addr);
> +	writel(upper_32_bits(val), addr + 4);
> +}

Could readq() and writeq() be used, rather than your own helpers?

	Andrew