linux-kernel - Re: [PATCH 2/2] rcuscale: Remove redundant WARN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <640af17a-958c-4321-89d4-8ab1f12986fb@paulmck-laptop>
Date: Thu, 24 Oct 2024 13:28:24 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: "Uladzislau Rezki (Sony)" <urezki@...il.com>
Cc: Frederic Weisbecker <frederic@...nel.org>, RCU <rcu@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Neeraj upadhyay <Neeraj.Upadhyay@....com>,
	Boqun Feng <boqun.feng@...il.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH 2/2] rcuscale: Remove redundant WARN_ON_ONCE() splat

On Thu, Oct 24, 2024 at 06:45:58PM +0200, Uladzislau Rezki (Sony) wrote:
> There are two places where WARN_ON_ONCE() is called two times
> in the error paths. One which is encapsulated into if() condition
> and another one, which is unnecessary, is placed in the brackets.
> 
> Remove an extra WARN_ON_ONCE() splat which is in brackets.
> 
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>

For both:

Reviewed-by: Paul E. McKenney <paulmck@...nel.org>

> ---
>  kernel/rcu/rcuscale.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
> index de7d511e6be4..1d8bb603c289 100644
> --- a/kernel/rcu/rcuscale.c
> +++ b/kernel/rcu/rcuscale.c
> @@ -889,13 +889,11 @@ kfree_scale_init(void)
>  
>  		if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) {
>  			pr_alert("ERROR: call_rcu() CBs are not being lazy as expected!\n");
> -			WARN_ON_ONCE(1);
>  			goto unwind;
>  		}
>  
>  		if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start > 3 * HZ)) {
>  			pr_alert("ERROR: call_rcu() CBs are being too lazy!\n");
> -			WARN_ON_ONCE(1);
>  			goto unwind;
>  		}
>  	}
> -- 
> 2.39.5
>