linux-kernel - Re: [PATCH v1 1/1] pwm: core: use device_match_name() instead of strcmp(dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2r7ey7fkt4k3s3kpi2vmesqrfntyd6jt7uf5jmwwbzglgxcohf@lr5gfy3ce2yu>
Date: Thu, 24 Oct 2024 22:55:36 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] pwm: core: use device_match_name() instead of
 strcmp(dev_name(...

Hello Andy,

On Thu, Oct 24, 2024 at 06:19:05PM +0300, Andy Shevchenko wrote:
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 634be56e204b..4399e793efaf 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -852,9 +852,7 @@ static struct pwm_chip *pwmchip_find_by_name(const char *name)
>  	guard(mutex)(&pwm_lock);
>  
>  	idr_for_each_entry_ul(&pwm_chips, chip, tmp, id) {
> -		const char *chip_name = dev_name(pwmchip_parent(chip));
> -
> -		if (chip_name && strcmp(chip_name, name) == 0)
> +		if (device_match_name(pwmchip_parent(chip), name))

This theoretically changes behaviour in a few cases. For example if
dev_name(pwmchip_parent(chip)) is NULL the new code would crash. Can
this happen? 

Best regards
Uwe

>  			return chip;
>  	}

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)