linux-kernel - Re: [PATCH] bus: mhi: host: Free mhi_buf vector inside mhi_alloc_bhie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4cb53edc-8030-54c9-0c26-09d188c2b4e2@quicinc.com>
Date: Thu, 24 Oct 2024 15:48:11 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Youssef Samir <quic_yabdulra@...cinc.com>,
        <manivannan.sadhasivam@...aro.org>
CC: <mhi@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bus: mhi: host: Free mhi_buf vector inside
 mhi_alloc_bhie_table()

On 10/24/2024 3:47 PM, Youssef Samir wrote:
> mhi_alloc_bhie_table() starts by allocating a vector of struct mhi_buf
> then it allocates a DMA buffer for each element. If allocation fails,
> it will free the allocated DMA buffers, but it neglects freeing the
> mhi_buf vector.
> 
> Avoid memory leaks by freeing the mhi_buf vector on error.
> 
> Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
> Signed-off-by: Youssef Samir <quic_yabdulra@...cinc.com>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
> ---
>   drivers/bus/mhi/host/boot.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
> index 21bf042db9be..2e9ef55a566a 100644
> --- a/drivers/bus/mhi/host/boot.c
> +++ b/drivers/bus/mhi/host/boot.c
> @@ -415,6 +415,7 @@ int mhi_alloc_bhie_table(struct mhi_controller *mhi_cntrl,
>   	for (--i, --mhi_buf; i >= 0; i--, mhi_buf--)
>   		dma_free_coherent(mhi_cntrl->cntrl_dev, mhi_buf->len,
>   				  mhi_buf->buf, mhi_buf->dma_addr);
> +	kfree(img_info->mhi_buf);
>   
>   error_alloc_mhi_buf:
>   	kfree(img_info);


Better  :)