linux-kernel - Re: [PATCH 1/2] rust: error: Add EOVERFLOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc15b5f4-9596-486e-a275-5cde82a92985@gmail.com>
Date: Thu, 24 Oct 2024 09:09:32 +0300
From: Abdiel Janulgue <abdiel.janulgue@...il.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: rust-for-linux@...r.kernel.org, a.hindborg@...nel.org,
 linux-kernel@...r.kernel.org, dakr@...hat.com, airlied@...hat.com,
 miguel.ojeda.sandonis@...il.com, wedsonaf@...il.com
Subject: Re: [PATCH 1/2] rust: error: Add EOVERFLOW



On 23/10/2024 14:39, Alice Ryhl wrote:
> On Wed, Oct 23, 2024 at 1:34 PM Abdiel Janulgue
> <abdiel.janulgue@...il.com> wrote:
>>
>> Trivial addition for missing EOVERFLOW error.
>>
>> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@...il.com>
>> ---
>>   rust/kernel/error.rs | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
>> index 7cd3bbab52f2..92bfdaaedb02 100644
>> --- a/rust/kernel/error.rs
>> +++ b/rust/kernel/error.rs
>> @@ -63,6 +63,7 @@ macro_rules! declare_err {
>>       declare_err!(EPIPE, "Broken pipe.");
>>       declare_err!(EDOM, "Math argument out of domain of func.");
>>       declare_err!(ERANGE, "Math result not representable.");
>> +    declare_err!(EOVERFLOW, "Value too large for defined data type.");
>>       declare_err!(ERESTARTSYS, "Restart the system call.");
>>       declare_err!(ERESTARTNOINTR, "System call was interrupted by a signal and will be restarted.");
>>       declare_err!(ERESTARTNOHAND, "Restart if no handler.");
> 
> The commit message should explain why you're adding it. What will you
> use it for?

Yup I forgot to include the intent of the change, which is needed in the 
next patch. But will fix in next update.

/Abdiel