linux-kernel - Re: [PATCH] pwm: imx-tpm: Use correct MODULO value for EPWM mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f65248cd396524ebe977ea48d87284e14c399c9.camel@iris-sensing.com>
Date: Thu, 24 Oct 2024 06:11:04 +0000
From: Erik Schumacher <erik.schumacher@...s-sensing.com>
To: "Frank.li@....com" <Frank.li@....com>
CC: "kernel@...gutronix.de" <kernel@...gutronix.de>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "ukleinek@...nel.org"
	<ukleinek@...nel.org>, "linux-pwm@...r.kernel.org"
	<linux-pwm@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: Re: [PATCH] pwm: imx-tpm: Use correct MODULO value for EPWM mode

Am Mittwoch, dem 23.10.2024 um 11:35 -0400 schrieb Frank Li:
> On Wed, Oct 23, 2024 at 12:33:53PM +0000, Erik Schumacher wrote:
> > The modulo register defines the period of the edge-aligned PWM mode
> > (which is the only mode implemented). The reference manual states:
> > "The EPWM period is determined by (MOD + 0001h) ..." So the value that
> > is written to the MOD register must therefore be one less than the
> > calculated period length.
> > A correct MODULO value is particularly relevant if the PWM has to output
> > a high frequency due to a low period value.
> > 
> This is bug fix,  add fix tag and cc stable
> 
> Frank

That's true. I will do a v2 with these tags.
Thank you!

Erik
>