linux-kernel - Re: [PATCH v2] PCI/pwrctl: pwrseq: abandon QCom WCN probe on pre-pwrseq device-trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdOQoUMyioczx8jkeUObUFoYbj88JYQUWERMthFuQ1aAA@mail.gmail.com>
Date: Thu, 24 Oct 2024 08:57:23 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v2] PCI/pwrctl: pwrseq: abandon QCom WCN probe on
 pre-pwrseq device-trees

On Wed, Oct 23, 2024 at 8:36 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Mon, Oct 07, 2024 at 11:24:46AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Old device trees for some platforms already define wifi nodes for the WCN
> > family of chips since before power sequencing was added upstream.
> >
> > These nodes don't consume the regulator outputs from the PMU and if we
> > allow this driver to bind to one of such "incomplete" nodes, we'll see
> > a kernel log error about the infinite probe deferral.
> >
> > Let's extend the driver by adding a platform data struct matched against
> > the compatible. This struct will now contain the pwrseq target string as
> > well as a validation function called right after entering probe(). For
> > Qualcomm WCN models, we'll check the existence of the regulator supply
> > property that indicates the DT is already using power sequencing and
> > return -ENODEV if it's not there, indicating to the driver model that
> > the device should not be bound to the pwrctl driver.
> >
> > Fixes: 6140d185a43d ("PCI/pwrctl: Add a PCI power control driver for power sequenced devices")
> > Reported-by: Johan Hovold <johan@...nel.org>
> > Closes: https://lore.kernel.org/all/Zv565olMDDGHyYVt@hovoldconsulting.com/
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Applied to pci/for-linus for v6.12, thanks.
>
> It would help me out to have a hint in the posting that this is
> intended for the current release, since by default everything is for
> the "next" release.
>

Noted.

Thanks,
Bartosz