[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <t63jnh4ncssaajq6ef4pnhsmn7jjp7cstw6q5gay5hxzfjjvrh@xuepiohildao>
Date: Thu, 24 Oct 2024 09:36:46 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
Lars Povlsen <lars.povlsen@...rochip.com>, Steen Hegelund <Steen.Hegelund@...rochip.com>,
horatiu.vultur@...rochip.com, jensemil.schulzostergaard@...rochip.com,
Parthiban.Veerasooran@...rochip.com, Raju.Lakkaraju@...rochip.com, UNGLinuxDriver@...rochip.com,
Richard Cochran <richardcochran@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, jacob.e.keller@...el.com,
ast@...erby.net, maxime.chevallier@...tlin.com, horms@...nel.org,
netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v2 13/15] dt-bindings: net: add compatible
strings for lan969x targets
On Thu, Oct 24, 2024 at 12:01:32AM +0200, Daniel Machon wrote:
> Add compatible strings for the twelve different lan969x targets that we
> support. Either a sparx5-switch or lan9691-switch compatible string
> provided on their own, or any lan969x-switch compatible string with a
> fallback to lan9691-switch.
>
> Also, add myself as a maintainer.
>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>
> Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>
> ---
> .../bindings/net/microchip,sparx5-switch.yaml | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> index fcafef8d5a33..dedfad526666 100644
> --- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> @@ -9,6 +9,7 @@ title: Microchip Sparx5 Ethernet switch controller
> maintainers:
> - Steen Hegelund <steen.hegelund@...rochip.com>
> - Lars Povlsen <lars.povlsen@...rochip.com>
> + - Daniel Machon <daniel.machon@...rochip.com>
>
> description: |
> The SparX-5 Enterprise Ethernet switch family provides a rich set of
> @@ -34,7 +35,24 @@ properties:
> pattern: "^switch@[0-9a-f]+$"
>
> compatible:
> - const: microchip,sparx5-switch
> + oneOf:
> + - enum:
> + - microchip,lan9691-switch
> + - microchip,sparx5-switch
> + - items:
> + - enum:
> + - microchip,lan969c-switch
> + - microchip,lan969b-switch
> + - microchip,lan969a-switch
> + - microchip,lan9699-switch
> + - microchip,lan9698-switch
> + - microchip,lan9697-switch
> + - microchip,lan9696-switch
> + - microchip,lan9695-switch
> + - microchip,lan9694-switch
> + - microchip,lan9693-switch
> + - microchip,lan9692-switch
Usual order is increasing, not descreasing. It's fine to keep different
style than usual, but then just keep it in mind and enforce on any
future changes (because I will not remember the exception here and I
will always ask for increasing alphanumerical order).
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists