linux-kernel - RE: [PATCH v4 4/9] PCI: imx6: Correct controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB8676B522DE767D2B0F1D1A058C4E2@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date: Thu, 24 Oct 2024 07:42:58 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC: "kw@...ux.com" <kw@...ux.com>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>, Frank
 Li <frank.li@....com>, "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"festevam@...il.com" <festevam@...il.com>, "s.hauer@...gutronix.de"
	<s.hauer@...gutronix.de>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [PATCH v4 4/9] PCI: imx6: Correct controller_id generation logic
 for i.MX7D

> -----Original Message-----
> From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> Sent: 2024年10月23日 0:56
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: kw@...ux.com; bhelgaas@...gle.com; lpieralisi@...nel.org; Frank Li
> <frank.li@....com>; l.stach@...gutronix.de; robh+dt@...nel.org;
> conor+dt@...nel.org; shawnguo@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; festevam@...il.com;
> s.hauer@...gutronix.de; linux-pci@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; kernel@...gutronix.de; imx@...ts.linux.dev
> Subject: Re: [PATCH v4 4/9] PCI: imx6: Correct controller_id generation logic
> for i.MX7D
> 
> On Tue, Oct 15, 2024 at 04:33:28PM +0800, Richard Zhu wrote:
> > i.MX7D only has one PCIe controller, so controller_id should always be 0.
> > The previous code is incorrect although yielding the correct result.
> > Fix by removing IMX7D from the switch case branch.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > ---
> >  drivers/pci/controller/dwc/pci-imx6.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> > b/drivers/pci/controller/dwc/pci-imx6.c
> > index 2ae6fa4b5d32..ca8714c625fe 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -1338,7 +1338,6 @@ static int imx_pcie_probe(struct platform_device
> *pdev)
> >  	switch (imx_pcie->drvdata->variant) {
> >  	case IMX8MQ:
> >  	case IMX8MQ_EP:
> > -	case IMX7D:
> >  		if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR)
> 
> This is just *wrong*. You cannot hardcode the MMIO address in the driver.
> Even though this code is old, you should fix it instead of building on top of it.
Hi Manivannan:
Thanks for your comments.
To avoid break DT compatibility, a proper method should be figured out to fix
 the hardcode here.
But it should be another story, how about to add this to the TO-DO list, and
issue the patch later?

Best Regards
Richard Zhu
> 
> - Mani
> 
> --
> மணிவண்ணன் சதாசிவம்