linux-kernel - Re: [PATCH -next] firmware_loader: Fix possible resource leak in fw_log_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9009cec-ce43-4288-98bf-1b6f216131c3@linux.intel.com>
Date: Thu, 24 Oct 2024 09:50:16 +0200
From: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>
To: Gaosheng Cui <cuigaosheng1@...wei.com>, mcgrof@...nel.org,
 russ.weight@...ux.dev, dakr@...hat.com, gregkh@...uxfoundation.org,
 rafael@...nel.org, cezary.rojewski@...el.com, wangweiyang2@...wei.com
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] firmware_loader: Fix possible resource leak in
 fw_log_firmware_info()

On 10/16/2024 1:03 PM, Gaosheng Cui wrote:
> The alg instance should be released under the exception path, otherwise
> there may be resource leak here.
> 
> To mitigate this, free the alg instance with crypto_free_shash when kmalloc
> fails.
> 
> Fixes: 02fe26f25325 ("firmware_loader: Add debug message with checksum for FW file")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> ---

Makes sense, thanks!

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>