linux-kernel - Re: [PATCH v1 00/13] iio: Clean up acpi_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zxn_61abUi2cAiQk@smile.fi.intel.com>
Date: Thu, 24 Oct 2024 11:06:03 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Marius Cristea <marius.cristea@...rochip.com>,
	Trevor Gamblin <tgamblin@...libre.com>,
	Hans de Goede <hdegoede@...hat.com>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
	Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>
Subject: Re: [PATCH v1 00/13] iio: Clean up acpi_match_device() use cases

On Thu, Oct 24, 2024 at 08:52:31AM +0100, Jonathan Cameron wrote:
> On Wed, 23 Oct 2024 18:17:23 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > There are current uses of acpi_match_device():
> > - as strange way of checking if the device was enumerated via ACPI
> > - as a way to get IIO device name as ACPI device instance name
> 
> Quick note on this one. That's an ABI bug that we are stuck with because
> we missed it in review a long time back and names aren't critical enough
> to justify forcing a fix through.
> 
> I don't have a particular problem with a function to wrap that up,
> but thought I'd just make it clear in this thread that no new
> driver should ever do this!

That's a good addition!

Let me cook a v2 where I add this to the kernel doc and actually I have to
update the SoB chain in one patch.

-- 
With Best Regards,
Andy Shevchenko