[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEHHSvY3QWkjDo6LdyFg-X+UnyY-cJ6kAFUYP-ZWBqgHoKxmkQ@mail.gmail.com>
Date: Thu, 24 Oct 2024 10:19:32 +0200
From: Julien Stephan <jstephan@...libre.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
Nuno Sá <nuno.sa@...log.com>,
David Lechner <dlechner@...libre.com>, Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Jonathan Corbet <corbet@....net>, linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: iio: adc: ad7380: add adaq4370-4 and
adaq4380-4 compatible parts
Le jeu. 24 oct. 2024 à 09:29, Krzysztof Kozlowski <krzk@...nel.org> a écrit :
>
> On Wed, Oct 23, 2024 at 11:19:33AM +0200, Julien Stephan wrote:
> > + vs-p-supply:
> > + description:
> > + Amplifiers positive supply.
> > +
> > + vs-n-supply:
> > + description:
> > + Amplifiers negative supply.
> > +
> > + ldo-supply:
> > + description:
> > + LDO supply. Connect to vs-p-supply or a 3.6 to 5.5 V supply.
> >
> > aina-supply:
> > description:
> > @@ -97,12 +115,46 @@ properties:
> > specify the ALERT interrupt.
> > maxItems: 1
> >
> > + '#address-cells':
>
> If there is going to be new version/resend, then keep consistent quotes:
> " or '.
>
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 0
> > +
> > required:
> > - compatible
> > - reg
> > - vcc-supply
> > - vlogic-supply
> >
> > +patternProperties:
> > + "^channel@([0-3])$":
>
> () are not necessary
>
> > + $ref: adc.yaml
> > + type: object
> > +
> > + properties:
> > + reg:
> > + description:
> > + The channel number. From 0 to 3 corresponding to channels A,B,C,D
> > + items:
> > + minimum: 0
> > + maximum: 3
>
> No improvements, no response to comment.
Hi Krzysztof,
I am sorry, it got lost during my rebase. It was planned to be on the
v2 (even added it to the changelog in the cover letter).
Thank you for noticing it. I sent a v3 with all the changes.
Cheers
Julien
>
> > +
> > + adi,gain-milli:
> > + description:
> > + The hardware gain applied to the ADC input (in milli units).
> > + If not present, default to 1000 (no actual gain applied).
> > + Refer to the typical connection diagrams section of the datasheet for
> > + pin wiring.
> > + $ref: /schemas/types.yaml#/definitions/uint16
> > + enum: [300, 600, 1000, 1600]
> > + default: 1000
> > +
> > + required:
> > + - reg
> > +
> > + additionalProperties: false
> > +
> > unevaluatedProperties: false
> >
> > allOf:
> > @@ -140,6 +192,7 @@ allOf:
> > aind-supply: false
> >
> > # ad7380-4 uses refin-supply as external reference.
> > + # adaq devices use internal reference only, derived from refin-supply
> > # All other chips from ad738x family use refio as optional external reference.
> > # When refio-supply is omitted, internal reference is used.
> > - if:
> > @@ -147,6 +200,8 @@ allOf:
> > compatible:
> > enum:
> > - adi,ad7380-4
> > + - adi,adaq4370-4
> > + - adi,adaq4380-4
> > then:
> > properties:
> > refio-supply: false
> > @@ -156,6 +211,27 @@ allOf:
> > properties:
> > refin-supply: false
> >
> > + # adaq devices need more supplies and using channel to declare gain property
> > + # only applies to adaq devices
> > + - if:
> > + properties:
> > + compatible:
> > + enum:
> > + - adi,adaq4370-4
> > + - adi,adaq4380-4
> > + then:
> > + required:
> > + - vs-p-supply
> > + - vs-n-supply
> > + - ldo-supply
> > + else:
> > + properties:
> > + vs-p-supply: false
> > + vs-n-supply: false
> > + ldo-supply: false
> > + patternProperties:
> > + "^channel@([0-3])$": false
>
> () are not necessary
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists