linux-kernel - Re: [PATCH 00/10] clockevents: Rearrange cpuhotplug operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmhx6grp.ffs@tglx>
Date: Thu, 24 Oct 2024 10:34:34 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Frederic Weisbecker <frederic@...nel.org>, LKML
 <linux-kernel@...r.kernel.org>
Cc: Frederic Weisbecker <frederic@...nel.org>, Daniel Lezcano
 <daniel.lezcano@...aro.org>, Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [PATCH 00/10] clockevents: Rearrange cpuhotplug operations

On Thu, Oct 17 2024 at 18:50, Frederic Weisbecker wrote:
> Some recent RCU issues triggered with offline ticks uncovered
> hotplug behaviour differences between oneshot and periodic ticks.
> The former is disabled on the dying CPU but not the latter. Also
> the clockevents hotplug code is quite chaotic. This is a proposal to
> fix the situation.

I like it very much!

> Frederic Weisbecker (10):
>   clockevents: Improve clockevents_notify_released() comment
>   clockevents: Shutdown and unregister current clockevents at
>     CPUHP_AP_TICK_DYING

This has a build fail.

>   tick: Remove now unneeded low-res tick stop on CPUHP_AP_TICK_DYING
>   arm/twd: Remove clockevents shutdown call on offlining

The ARM prefix preference is:

    ARM: smp_twd:

>   clocksource/drivers/arm_arch_timer: Remove clockevents shutdown call
>     on offlining
>   clocksource/driver/arm_global_timer: Remove clockevents shutdown call
>     on offlining
>   drivers/clocksource/exynos_mct: Remove clockevents shutdown call on
>     offlining
>   clocksource/drivers/armada-370-xp: Remove clockevents shutdown call on
>     offlining
>   clocksource/drivers/qcom: Remove clockevents shutdown call on
>     offlining
>   drivers/clocksource/timer-tegra: Remove clockevents shutdown call on
>     offlining

Can you please make the subsystem prefixes for the clocksource drivers
consistent 'clocksource/drivers/foo:' ?

Thanks,

        tglx