Message-ID: <32cb6d9388fb136f7cd7ad1ab0d60d83ae387982.camel@codeconstruct.com.au>
Date: Thu, 24 Oct 2024 10:48:22 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: 徐傑生 <jasonhell19@...il.com>
Cc: yang.chen@...ntatw.com, jerry.lin@...ntatw.com, robh@...nel.org, 
 krzk+dt@...nel.org, conor+dt@...nel.org, joel@....id.au, patrick@...cx.xyz,
  devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] Add Meta(Facebook) Ventura BMC(AST2600)

On Wed, 2024-10-23 at 16:32 +0800, 徐傑生 wrote:
> Andrew Jeffery <andrew@...econstruct.com.au> 於 2024年10月23日 週三 下午2:15寫道：
> > 
> > On Tue, 2024-10-22 at 10:12 +0800, Jason-Hsu wrote:
> > > Add Linux device tree entry related to Meta(Facebook) Ventura specific
> > > devices connected to BMC(AST2600) SoC.
> > > 
> > > Signed-off-by: Jason-Hsu <jasonhell19@...il.com>
> > 
> > What commands are you running to generate and send your patch series?
> > 
> > The patches must be threaded properly.
> > 
> > `git send-email` or `b4` both do what is expected without any effort
> > required. Please consider using them, particularly b4, if you're not
> > already.
> > 
> > Andrew
> 
> We use `git format-patch` and `git send-email` command to generate and
> send patch series as below, could you help to check?  Thank you.
> 
> git format-patch -2 --cover-letter
> 
> git send-email --smtp-debug --to=robh@...nel.org
> --to=krzk+dt@...nel.org --to=conor+dt@...nel.org --to=joel@....id.au
> --to=andrew@...econstruct.com.au --to=patrick@...cx.xyz
> --to=devicetree@...r.kernel.org
> --to=linux-arm-kernel@...ts.infradead.org
> --to=linux-aspeed@...ts.ozlabs.org --to=linux-kernel@...r.kernel.org
> --cc=yang.chen@...ntatw.com --cc=jerry.lin@...ntatw.com *.patch
> 

So from the details in the cover letter I'm guessing that you're using
Ubuntu 22.04 LTS (Jammy). At least, Jammy ships git-2.34.1, which is
what is mentioned in the cover letter.

The --thread option in the man-page for git-format-patch[1] says:

   The default is --no-thread, unless the format.thread configuration is
   set. If --thread is specified without a style, it defaults to the style
   specified by format.thread if any, or else shallow.
   
   Beware that the default for git send-email is to thread emails itself.
   If you want git format-patch to take care of threading, you will want
   to ensure that threading is disabled for git send-email.

[1]: https://manpages.ubuntu.com/manpages/jammy/en/man1/git-format-patch.1.html

The --thread option in the man-page for git-send-email[2] says:

   If disabled with "--no-thread", those headers will not be added (unless
   specified with --in-reply-to). Default is the value of the
   sendemail.thread configuration value; if that is unspecified, default
   to --thread.

[2]: https://manpages.ubuntu.com/manpages/jammy/en/man1/git-send-email.1.html

Since you're not supplying any thread-related arguments in either case,
I wonder if you have thread values set in your git config. What's the
output of the following two commands for you?

   $ git config --show-scope --get format.thread
   $ git config --show-scope --get sendemail.thread

Regardless, you may want to try passing `--thread` in your `git send-
email` invocation.

Finally, please pass `-v $X` to `git format-patch` to version your
series (the value for X is how many times you've sent revisions of the
series). Currently I count 3 distinct attempts, so next time you send
out the patches you should pass `-v 4`. However, the b4 tool is helpful
here, as it largely automates the process for you.

Andrew

Powered by blists - more mailing lists