lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <30301f0b-5b04-4150-8159-5b8721486d6c@arm.com>
Date: Thu, 24 Oct 2024 11:36:42 +0100
From: Suzuki K Poulose <suzuki.poulose@....com>
To: Tao Zhang <quic_taozha@...cinc.com>, Mike Leach <mike.leach@...aro.org>,
 James Clark <james.clark@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>,
 Leo Yan <leo.yan@...ux.dev>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc: coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: arm:
 qcom,coresight-static-replicator: Add property for source filtering

On 24/10/2024 10:14, Suzuki K Poulose wrote:
> On 24/10/2024 07:53, Tao Zhang wrote:
>> The is some "magic" hard coded filtering in the replicators,
>> which only passes through trace from a particular "source". Add
>> a new property "filter-src" to label a phandle to the coresight
>> trace source device matching the hard coded filtering for the port.
> 
> As mentioned in here in v3 review :
> 
> https://lkml.org/lkml/2024/8/21/597
> 
> Please do not use "src", expand it to "source"

Just to confirm, this is only for the "bindings" string, not for the 
variables used in the patches.

Suzuki


> 
> Rest looks fine.
> 
> Suzuki
> 
>>
>> Signed-off-by: Tao Zhang <quic_taozha@...cinc.com>
>> ---
>>   .../arm/arm,coresight-static-replicator.yaml  | 19 ++++++++++++++++++-
>>   1 file changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
>> index 1892a091ac35..0d258c79eb94 100644
>> --- 
>> a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
>> +++ 
>> b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
>> @@ -45,7 +45,22 @@ properties:
>>       patternProperties:
>>         '^port@[01]$':
>>           description: Output connections to CoreSight Trace bus
>> -        $ref: /schemas/graph.yaml#/properties/port
>> +        $ref: /schemas/graph.yaml#/$defs/port-base
>> +        unevaluatedProperties: false
>> +
>> +        properties:
>> +          endpoint:
>> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base
>> +            unevaluatedProperties: false
>> +
>> +            properties:
>> +              filter-src:
>> +                $ref: /schemas/types.yaml#/definitions/phandle
>> +                description:
>> +                  phandle to the coresight trace source device 
>> matching the
>> +                  hard coded filtering for this port
>> +
>> +              remote-endpoint: true
>>   required:
>>     - compatible
>> @@ -72,6 +87,7 @@ examples:
>>                   reg = <0>;
>>                   replicator_out_port0: endpoint {
>>                       remote-endpoint = <&etb_in_port>;
>> +                    filter-src = <&tpdm_video>;
>>                   };
>>               };
>> @@ -79,6 +95,7 @@ examples:
>>                   reg = <1>;
>>                   replicator_out_port1: endpoint {
>>                       remote-endpoint = <&tpiu_in_port>;
>> +                    filter-src = <&tpdm_mdss>;
>>                   };
>>               };
>>           };
> 


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ