linux-kernel - Re: [PATCH v4 17/28] cxl/events: Split event msgnum configuration from irq setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6719b1f1c7dd_da1f929462@iweiny-mobl.notmuch>
Date: Wed, 23 Oct 2024 21:33:21 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Fan Ni <nifan.cxl@...il.com>, Ira Weiny <ira.weiny@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>, Jonathan Cameron
	<Jonathan.Cameron@...wei.com>, Navneet Singh <navneet.singh@...el.com>,
	Jonathan Corbet <corbet@....net>, Andrew Morton <akpm@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>, Davidlohr Bueso <dave@...olabs.net>,
	Alison Schofield <alison.schofield@...el.com>, Vishal Verma
	<vishal.l.verma@...el.com>, <linux-btrfs@...r.kernel.org>,
	<linux-cxl@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 17/28] cxl/events: Split event msgnum configuration
 from irq setup

Fan Ni wrote:
> On Mon, Oct 07, 2024 at 06:16:23PM -0500, Ira Weiny wrote:
> > Dynamic Capacity Devices (DCD) require event interrupts to process
> > memory addition or removal.  BIOS may have control over non-DCD event
> > processing.  DCD interrupt configuration needs to be separate from
> > memory event interrupt configuration.
> > 
> > Split cxl_event_config_msgnums() from irq setup in preparation for
> > separate DCD interrupts configuration.
> > 
> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> > ---
> One minor comment inline; otherwise
> 
> Reviewed-by: Fan Ni <fan.ni@...sung.com>
> 

[snip]

> >  
> > -	rc = cxl_event_req_irq(cxlds, policy.fatal_settings);
> > +	rc = cxl_event_req_irq(cxlds, policy->fatal_settings);
> >  	if (rc) {
> >  		dev_err(cxlds->dev, "Failed to get interrupt for event Fatal log\n");
> >  		return rc;
> 
> There is a lot of duplicate code here, can we simplify it by
> iteratting all setttings in cxl_event_interrrupt_policy like 
> 
> for setting in policy:
>     rc = cxl_event_req_irq(cxlds, setting);
>     if (rc) {
>         ...
>     }
>

Do you mean by treating struct cxl_event_interrupt_policy as an u8 array?

I'm not sure that is super beneficial.

Ira

> 
> For DCD, handle the setup separately afterwards.
> 
> Fan

[snip]