linux-kernel - Re: [PATCH] pmdomain: imx: gpcv2: replace dev_err() with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a96c142-0d2d-4bdb-8211-06958250841b@linaro.org>
Date: Thu, 24 Oct 2024 12:58:37 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
 linux-kernel@...r.kernel.org
Cc: linux-amarula@...rulasolutions.com,
 Michael Trimarchi <michael@...rulasolutions.com>,
 Fabio Estevam <festevam@...il.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Shengjiu Wang <shengjiu.wang@....com>, Ulf Hansson <ulf.hansson@...aro.org>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH] pmdomain: imx: gpcv2: replace dev_err() with
 dev_err_probe()

On 24/10/2024 12:35, Dario Binacchi wrote:
> The patch standardizes the probe() code by replacing the two occurrences
> of dev_err() with dev_err_probe(). Indeed, dev_err_probe() was used in all
> other error paths of the probe() function.

But why? Does not simplify the code and called function cannot defer. It
prints error, but your commit does not mention this as benefit.

Best regards,
Krzysztof