linux-kernel - Re: [PATCH 5/7] iio: imu: inv_mpu6050: simplify code in write_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <FR3P281MB175799CC4895C8BC5B645236CE4E2@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Date: Thu, 24 Oct 2024 12:16:42 +0000
From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
To: Julien Stephan <jstephan@...libre.com>,
        Mudit Sharma
	<muditsharma.info@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter
 Clausen <lars@...afoo.de>,
        Anshul Dalal <anshulusr@...il.com>,
        Javier
 Carrasco <javier.carrasco.cruz@...il.com>,
        Michael Hennerich
	<Michael.Hennerich@...log.com>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Ramona Gradinariu <ramona.gradinariu@...log.com>,
        Antoniu Miclaus
	<antoniu.miclaus@...log.com>,
        Dan Robertson <dan@...obertson.com>,
        Marcelo
 Schmitt <marcelo.schmitt@...log.com>,
        Matteo Martelli
	<matteomartelli3@...il.com>,
        Anand Ashok Dumbre
	<anand.ashok.dumbre@...inx.com>,
        Michal Simek <michal.simek@....com>,
        Mariel
 Tinaco <Mariel.Tinaco@...log.com>,
        Jagath Jog J <jagathjog1996@...il.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Subhajit Ghosh
	<subhajit.ghosh@...aklogic.com>,
        Kevin Tsai <ktsai@...ellamicro.com>,
        Linus
 Walleij <linus.walleij@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "chrome-platform@...ts.linux.dev"
	<chrome-platform@...ts.linux.dev>
Subject: Re: [PATCH 5/7] iio: imu: inv_mpu6050: simplify code in
 write_event_config callback

Hello Julien,

good thing to know, thanks for the patch.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>

Best regards,
JB

________________________________________
From: Julien Stephan <jstephan@...libre.com>
Sent: Thursday, October 24, 2024 11:11
To: Mudit Sharma <muditsharma.info@...il.com>; Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; Anshul Dalal <anshulusr@...il.com>; Javier Carrasco <javier.carrasco.cruz@...il.com>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>; Michael Hennerich <Michael.Hennerich@...log.com>; Cosmin Tanislav <cosmin.tanislav@...log.com>; Ramona Gradinariu <ramona.gradinariu@...log.com>; Antoniu Miclaus <antoniu.miclaus@...log.com>; Dan Robertson <dan@...obertson.com>; Marcelo Schmitt <marcelo.schmitt@...log.com>; Matteo Martelli <matteomartelli3@...il.com>; Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>; Michal Simek <michal.simek@....com>; Mariel Tinaco <Mariel.Tinaco@...log.com>; Jagath Jog J <jagathjog1996@...il.com>; Lorenzo Bianconi <lorenzo@...nel.org>; Subhajit Ghosh <subhajit.ghosh@...aklogic.com>; Kevin Tsai <ktsai@...ellamicro.com>; Linus Walleij <linus.walleij@...aro.org>; Benson Leung <bleung@...omium.org>; Guenter Roeck <groeck@...omium.org>
Cc: linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; linux-arm-kernel@...ts.infradead.org <linux-arm-kernel@...ts.infradead.org>; chrome-platform@...ts.linux.dev <chrome-platform@...ts.linux.dev>; Julien Stephan <jstephan@...libre.com>
Subject: [PATCH 5/7] iio: imu: inv_mpu6050: simplify code in write_event_config callback
 
This Message Is From an External Sender
This message came from outside your organization.
 
iio_ev_state_store is actually using kstrtobool to check user
input, then gives the converted boolean value to the write_event_config
callback.

Remove useless code in write_event_config callback.

Signed-off-by: Julien Stephan <jstephan@...libre.com>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 7 ++-----
 drivers/iio/light/apds9960.c               | 2 --
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
index 5680be153127711777b6074da18a7a0f86211d6c..21ebf0f7e28fec302cbf8ab890fc53a3de6f36cd 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
@@ -1176,21 +1176,18 @@ static int inv_mpu6050_write_event_config(struct iio_dev *indio_dev,
 					  int state)
 {
 	struct inv_mpu6050_state *st = iio_priv(indio_dev);
-	int enable;
 
 	/* support only WoM (accel roc rising) event */
 	if (chan->type != IIO_ACCEL || type != IIO_EV_TYPE_ROC ||
 	    dir != IIO_EV_DIR_RISING)
 		return -EINVAL;
 
-	enable = !!state;
-
 	guard(mutex)(&st->lock);
 
-	if (st->chip_config.wom_en == enable)
+	if (st->chip_config.wom_en == state)
 		return 0;
 
-	return inv_mpu6050_enable_wom(st, enable);
+	return inv_mpu6050_enable_wom(st, state);
 }
 
 static int inv_mpu6050_read_event_value(struct iio_dev *indio_dev,
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index 3c14e4c30805e1b596ef2380f94e6aa3e92082b1..3a56eaae5a68f2891d061871c7013f0b5447bb47 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -762,8 +762,6 @@ static int apds9960_write_event_config(struct iio_dev *indio_dev,
 	struct apds9960_data *data = iio_priv(indio_dev);
 	int ret;
 
-	state = !!state;
-
 	switch (chan->type) {
 	case IIO_PROXIMITY:
 		if (data->pxs_int == state)

-- 
2.47.0