linux-kernel - Re: [PATCH v2 02/13] iio: adc: pac1934: Replace strange way of checking type of enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fa19c12e335ce00414a971d16867322c9bdad7b.camel@microchip.com>
Date: Thu, 24 Oct 2024 13:25:28 +0000
From: <Marius.Cristea@...rochip.com>
To: <hdegoede@...hat.com>, <andriy.shevchenko@...ux.intel.com>,
	<Jonathan.Cameron@...wei.com>, <tgamblin@...libre.com>,
	<jean-baptiste.maneyrol@....com>, <linux-iio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC: <jic23@...nel.org>, <lars@...afoo.de>
Subject: Re: [PATCH v2 02/13] iio: adc: pac1934: Replace strange way of
 checking type of enumeration

Hi Andy,

  Thank you for the patch. It looks OK for me.

Reviewed-by: Marius Cristea <marius.cristea@...rochip.com>

Regards,
Marius


On Thu, 2024-10-24 at 15:36 +0300, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> When device is enumerated via ACPI the respective device node is of
> ACPI device type. Use that to check for ACPI enumeration, rather than
> calling for full match which is O(n) vs. O(1) for the regular check.
> 
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/iio/adc/pac1934.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
> index 7ef249d83286..20802b7f49ea 100644
> --- a/drivers/iio/adc/pac1934.c
> +++ b/drivers/iio/adc/pac1934.c
> @@ -1507,7 +1507,7 @@ static int pac1934_probe(struct i2c_client
> *client)
>                 indio_dev->name = pac1934_chip_config[ret].name;
>         }
> 
> -       if (acpi_match_device(dev->driver->acpi_match_table, dev))
> +       if (is_acpi_device_node(dev_fwnode(dev)))
>                 ret = pac1934_acpi_parse_channel_config(client,
> info);
>         else
>                 /*
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>