linux-kernel - Re: [PATCH v3] xhci: Fix Link TRB DMA in command ring stopped completion event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9a2eb47-512e-4718-a83a-4742e09be85b@linux.intel.com>
Date: Thu, 24 Oct 2024 17:06:44 +0300
From: Mathias Nyman <mathias.nyman@...ux.intel.com>
To: Faisal Hassan <quic_faisalh@...cinc.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Mathias Nyman <mathias.nyman@...el.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH v3] xhci: Fix Link TRB DMA in command ring stopped
 completion event

On 22.10.2024 18.56, Faisal Hassan wrote:
> During the aborting of a command, the software receives a command
> completion event for the command ring stopped, with the TRB pointing
> to the next TRB after the aborted command.
> 
> If the command we abort is located just before the Link TRB in the
> command ring, then during the 'command ring stopped' completion event,
> the xHC gives the Link TRB in the event's cmd DMA, which causes a
> mismatch in handling command completion event.
> 
> To address this situation, move the 'command ring stopped' completion
> event check slightly earlier, since the specific command it stopped
> on isn't of significant concern.
> 
> Fixes: 7f84eef0dafb ("USB: xhci: No-op command queueing and irq handler.")
> Cc: stable@...r.kernel.org
> Signed-off-by: Faisal Hassan <quic_faisalh@...cinc.com>

Acked-by: Mathias Nyman <mathias.nyman@...ux.intel.com>

Greg, would you like to take this directly to usb-linus (6.12)?
If not I'll send it as part of series to usb-next later

Thanks
Mathias