linux-kernel - Re: [PATCH 1/1] add comment for doi_remove in struct netlbl_lsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241025134028.GW1202098@kernel.org>
Date: Fri, 25 Oct 2024 14:40:28 +0100
From: Simon Horman <horms@...nel.org>
To: George Guo <dongtai.guo@...ux.dev>
Cc: pabeni@...hat.com, davem@...emloft.net, edumazet@...gle.com,
	guodongtai@...inos.cn, kuba@...nel.org,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org,
	netdev@...r.kernel.org, paul@...l-moore.com
Subject: Re: [PATCH 1/1] add comment for doi_remove in struct
 netlbl_lsm_secattr

On Fri, Oct 25, 2024 at 02:40:31PM +0800, George Guo wrote:
> From: George Guo <guodongtai@...inos.cn>

Hi George,

Thanks for your patch. I agree that is is correct and a good change
to make. But there are some process issues to be addressed before this
patch can be accepted.

Firstly, as this is presumably a non-bug fix for networking code,
it should be targeted at the net-next tree. That it should
be based on that tree (it seems to be) and explicitly targeted
at that tree in the Subject.

  Subject: [PATCH net-next v2] ...

Secondly, the subject should include a prefix.
Looking at git log include/net/netlabel.h it
seems that should be 'netlabel:'

  Subject: [PATCH net-next v2] netlabel: ...

And it might be best to make the subject a bit more descriptive.

  Subject: [PATCH net-next v2] netlabel: document doi_remove field of struct netlbl_calipso_ops

Next, a commit message is required. It should explain why the change is
being made. And, ideally how you found this problem. It should
also include a Signed-off-by line [1]. e.g.

  Add documentation of do_remove field to Kernel doc for struct
  netlbl_calipso_ops.

  Found using W=1 build.

  Signed-off-by: ...

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Lastly, please do wait 24h before posting a new version.
Please include information about what has changed below the scissors ('---').
And please send the new patch as a new thread.

More information on development processes for Networking can be found here:
https://docs.kernel.org/process/maintainer-netdev.html

...

-- 
pw-bot: changes-requested