linux-kernel - Re: [PATCH 1/1] i3c: master: svc: Modify enabled_events bit 7:0 to act as IBI enable counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxukksXwyWN2HQ3I@lizhi-Precision-Tower-5810>
Date: Fri, 25 Oct 2024 10:00:50 -0400
From: Frank Li <Frank.li@....com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Conor Culhane <conor.culhane@...vaco.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Clark Wang <xiaoning.wang@....com>,
	"moderated list:SILVACO I3C DUAL-ROLE MASTER" <linux-i3c@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] i3c: master: svc: Modify enabled_events bit 7:0 to
 act as IBI enable counter

On Fri, Oct 25, 2024 at 09:53:18AM +0200, Miquel Raynal wrote:
> Hi Frank,
>
> Frank.Li@....com wrote on Thu, 24 Oct 2024 16:38:55 -0400:
>
> > Fix issue where disabling IBI on one device disables the entire IBI
> > interrupt. Modify bit 7:0 of enabled_events to serve as an IBI enable
>
> Is this bitfield arbitrary?
>
> Is there a rationale behind it?

Max devices number under a I3C bus is 128 because dynamic address is 7 bit.
So 8 bits for it should be enough.

Bit31 as hotjoin, Bit30 reserved as control switch request.

Frank

>
> > counter, ensuring that the system IBI interrupt is disabled only when all
> > I3C devices have IBI disabled.
> >
> > Cc: stable@...nel.org
> > Fixes: 7ff730ca458e ("i3c: master: svc: enable the interrupt in the enable ibi function")
> > Signed-off-by: Frank Li <Frank.Li@....com>
>
> Anyway,
>
> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
>
> Thanks,
> Miquèl