[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zxult8UK90H7z3KV@smile.fi.intel.com>
Date: Fri, 25 Oct 2024 17:05:43 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: John Ogness <john.ogness@...utronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>, Petr Mladek <pmladek@...e.com>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Steven Rostedt <rostedt@...dmis.org>,
Thomas Gleixner <tglx@...utronix.de>,
Esben Haabendal <esben@...nix.com>, linux-serial@...r.kernel.org,
linux-kernel@...r.kernel.org,
Rengarajan S <rengarajan.s@...rochip.com>,
Peter Collingbourne <pcc@...gle.com>,
Serge Semin <fancer.lancer@...il.com>,
Lino Sanfilippo <l.sanfilippo@...bus.com>
Subject: Re: [PATCH tty-next v3 6/6] serial: 8250: Revert "drop lockdep
annotation from serial8250_clear_IER()"
On Fri, Oct 25, 2024 at 01:03:28PM +0206, John Ogness wrote:
> The 8250 driver no longer depends on @oops_in_progress and
> will no longer violate the port->lock locking constraints.
>
> This reverts commit 3d9e6f556e235ddcdc9f73600fdd46fe1736b090.
...
> + /* Port locked to synchronize UART_IER access against the console. */
Nevertheless, the same comment about the one-liner comment style.
Do we need a period? Perhaps drop it here while at it?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists