linux-kernel - Re: [PATCH] RAS/AMD/FMPM: Remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8412cc2d-7713-4a79-a7e8-5759e3320aa6@stanley.mountain>
Date: Fri, 25 Oct 2024 17:06:57 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] RAS/AMD/FMPM: Remove some dead code

On Fri, Oct 25, 2024 at 09:56:16AM -0400, Yazen Ghannam wrote:
> On Fri, Oct 25, 2024 at 10:08:34AM +0300, Dan Carpenter wrote:
> > Debugfs functions don't return NULL, they return error pointers.  Debugfs
> > functions are slightly unusual because they're not supposed to be checked
> > for errors in the normal case.  Delete these checks.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  drivers/ras/amd/fmpm.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
> > index 90de737fbc90..3cde1fe17a7a 100644
> > --- a/drivers/ras/amd/fmpm.c
> > +++ b/drivers/ras/amd/fmpm.c
> > @@ -956,12 +956,7 @@ static void setup_debugfs(void)
> >  		return;
> >  
> >  	fmpm_dfs_dir = debugfs_create_dir("fmpm", dfs);
> > -	if (!fmpm_dfs_dir)
> > -		return;
> > -
> >  	fmpm_dfs_entries = debugfs_create_file("entries", 0400, fmpm_dfs_dir, NULL, &fmpm_fops);
> > -	if (!fmpm_dfs_entries)
> > -		debugfs_remove(fmpm_dfs_dir);
> >  }
> >  
> >  static const struct x86_cpu_id fmpm_cpuids[] = {
> > -- 
> 
> Seems like we had the same idea. :)
> 
> https://lore.kernel.org/r/20241024155503.GA965@yaz-khff2.amd.com
> 

Ah.  Good.  To me it's always encouraging when people end up writing basically
the exact same patch.

regards,
dan carpenter