linux-kernel - Re: [PATCH] arm64: dts: renesas: hihope: Drop #sound-dai-cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVX7hYdH3iLKttqkYeTC_ZGyCNmSycUtUx+QKSDCjaP1g@mail.gmail.com>
Date: Fri, 25 Oct 2024 16:25:23 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Prabhakar <prabhakar.csengg@...il.com>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Subject: Re: [PATCH] arm64: dts: renesas: hihope: Drop #sound-dai-cells

CC morimoto-san

On Thu, Oct 10, 2024 at 3:53 PM Prabhakar <prabhakar.csengg@...il.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> `#sound-dai-cells` is required if board is using "simple-card", and on
> the hihope board we are using "audio-graph" thus remove the unneeded
> `#sound-dai-cells`.
>
> Commit 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when
> simple-card") updated the comment regarding usage of `#sound-dai-cells`
> in SoC DTSI but missed to remove the `#sound-dai-cells` from board DTS
> files.
>
> Fixes: 9e72606cd2db ("arm64: dts: renesas: #sound-dai-cells is used when simple-card")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v6.13, unless Morimoto-san objects.

> diff --git a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
> index 8e2db1d6ca81..25c55b32aafe 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-rev2.dtsi
> @@ -69,9 +69,6 @@ &rcar_sound {
>
>         status = "okay";
>
> -       /* Single DAI */
> -       #sound-dai-cells = <0>;
> -
>         rsnd_port: port {
>                 rsnd_endpoint: endpoint {
>                         remote-endpoint = <&dw_hdmi0_snd_in>;
> diff --git a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
> index 66f3affe0469..deb69c272775 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-rev4.dtsi
> @@ -84,9 +84,6 @@ &rcar_sound {
>         pinctrl-names = "default";
>         status = "okay";
>
> -       /* Single DAI */
> -       #sound-dai-cells = <0>;
> -
>         /* audio_clkout0/1/2/3 */
>         #clock-cells = <1>;
>         clock-frequency = <12288000 11289600>;

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds